[ovs-dev] [PATCH 1/4] debian: Use DODTIME instead of DIETIME in init scripts

Justin Pettit jpettit at nicira.com
Fri Sep 24 01:22:19 UTC 2010


On Sep 23, 2010, at 4:38 PM, Ben Pfaff wrote:

> On Thu, Sep 23, 2010 at 04:34:42PM -0700, Justin Pettit wrote:
>> Brad pointed out that openvswitch-ipsec init script defined the variable
>> DIETIME but attempted to use it as DODTIME.  This commit uses DODTIME,
>> since it's the name used by the openvswitch-switch init script.  The
>> openvswitch-controller init script had the same issue.
>> 
>> Reported-by: Brad Hall <brad at nicira.com>
> 
> Looks good to me.
> 
> I'd drop the "s" suffixes on those command arguments.  They're a GNU
> extension and seconds is the default unit anyway.


Good to know.  I dropped them from these files and openvswitch-switch.init, which did the same thing.

--Justin






More information about the dev mailing list