[ovs-dev] [PATCH 3/4] vswitch: Disable header-caching when IPsec is enabled

[Justin Pettit]

On Sep 23, 2010, at 4:42 PM, Ben Pfaff wrote:

>> +    /* Include "other_config" keys in hash of netdev options.  The
>> +     * namespace of "other_config" and "options" must be disjoint.
>> +     * Prefer "options" keys over "other_config" keys. */
>> +    for (i = 0; i < iface_cfg->n_other_config; i++) {
>> +        if (!shash_add_once(&options, iface_cfg->key_other_config[i],
>> +                            xstrdup(iface_cfg->value_other_config[i]))) {
>> +            VLOG_WARN("%s: 'other_config' key %s conflicts with existing "
>> +                      "'other_config' or 'options' entry...ignoring",
>> +                      iface_cfg->name, iface_cfg->key_other_config[i]);
>> +        }
>> +    }
>> +
> 
> this leaks the "value" string each time it logs a message.  

Whoops.  Thanks!

> Also
> elsewhere we use "quotes" for quoting in messages instead of
> 'apostrophes'.

It looks like it's a pretty close to 50/50 split throughout the code with a slight preference towards quotes.  However, based on your preference, I went ahead and changed them to quotes.

--Justin