[ovs-dev] [netlink 02/16] datapath: Make adding and attaching a vport a single step.

[Jesse Gross]

On Thu, Sep 23, 2010 at 7:10 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Fri, Sep 10, 2010 at 3:55 PM, Ben Pfaff <blp at nicira.com> wrote:
>> For some time now, Open vSwitch datapaths have internally made a
>> distinction between adding a vport and attaching it to a datapath.  Adding
>> a vport just means to create it, as an entity detached from any datapath.
>> Attaching it gives it a port number and a datapath.  Similarly, a vport
>> could be detached and deleted separately.
>>
>> After some study, I think I understand why this distinction exists.  It is
>> because ovs-vswitchd tries to open all the datapath ports before it tries
>> to create them.  However, changing it to create them before it tries to
>> open them is not difficult, so this commit does this.
>>
>> The bulk of this commit, however, changes the datapath interface to one
>> that always creates a vport and attaches it to a datapath in a single step,
>> and similarly detaches a vport and deletes it in a single step.
>
> Thanks for unifying this.  It's definitely the right way to do it.

One additional thing: I received a trailing whitespace warning when
applying this (also on patches 14 and 16).  It would be nice to clean
that up.