[ovs-dev] [PATCH 2/2] cfm: Allow time for CCM reception after cfm_configure();

Ethan Jackson ethan at nicira.com
Fri Apr 1 20:48:40 UTC 2011


Thanks for the quick reviews, I merged this.

Ethan

On Fri, Apr 1, 2011 at 1:44 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Apr 01, 2011 at 01:37:10PM -0700, Ethan Jackson wrote:
>> Before this (and the previous) patch, whenever cfm_configure was
>> called it would set the fault_timer to expired.  Thus, the next
>> call to cfm_run would notice a lack of CCM reception and trigger a
>> faulted status.  This is a bug in and of itself, but normally would
>> not be a big deal because cfm_configure should only be called
>> infrequently (when the database changes).  However due to an
>> unrelated bug, cfm_configure() was getting called approximately once
>> per second.  This resulted in all monitors showing faults all of
>> the time.
>>
>> This patch fixes the problem by not expiring the timer at
>> cfm_configure().  Instead it gives it the appropriate
>> fault_interval amount of time to miss heartbeats.
>>
>> Bug #5244.
>
> Looks good.  Thank you!
>



More information about the dev mailing list