[ovs-dev] [idl 2/2] bridge: Monitor fewer OVSDB columns.

[Justin Petbot]

On Fri,  1 Apr 2011, at 10:51:40 AM, Ben Pfaff wrote:
> By omitting columns that ovs-vswitchd does not use at all, and omitting
> alerts for columns that ovs-vswitchd writes to but does not read, we can
> save CPU time and bandwidth.
> ---
>  vswitchd/bridge.c |   38 ++++++++++++++++++++++++++++++++++++++
>  1 files changed, 38 insertions(+), 0 deletions(-)
> 
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 186e409..405c59c 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -283,16 +283,54 @@ bridge_init(const char *remote)
>      ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_cur_cfg);
>      ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_statistics);
>      ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_external_ids);
> +    ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_ovs_version);
> +    ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_db_version);
> +    ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_type);
> +    ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_version);
>  
> +    ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_id);
>      ovsdb_idl_omit(idl, &ovsrec_bridge_col_external_ids);
>  
>      ovsdb_idl_omit(idl, &ovsrec_port_col_external_ids);
>      ovsdb_idl_omit(idl, &ovsrec_port_col_fake_bridge);
>  
> +    ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_admin_state);
> +    ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_duplex);
> +    ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_speed);

Is there a reason not to compile the parameter here?

> +    ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_state);
> +    ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mtu);

You might want to fix the grammar below.

>      ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ofport);
>      ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_statistics);
> +    ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_status);

Did you mean "svec" instead of "ovsrec_interface_col_status" here?

>      ovsdb_idl_omit(idl, &ovsrec_interface_col_external_ids);
>  
> +    ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_is_connected);
> +    ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_role);
> +    ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_status);

You might want to fix the grammar here.

> +    ovsdb_idl_omit(idl, &ovsrec_controller_col_external_ids);
> +
> +    ovsdb_idl_omit_alert(idl, &ovsrec_maintenance_point_col_fault);
> +
> +    ovsdb_idl_omit_alert(idl, &ovsrec_monitor_col_fault);

Why did this work before?

> +
> +    ovsdb_idl_omit(idl, &ovsrec_qos_col_external_ids);
> +
> +    ovsdb_idl_omit(idl, &ovsrec_queue_col_external_ids);

Every time you attend an OpenFlow meeting, you should get a certificate
from Sajjad.

> +
> +    ovsdb_idl_omit(idl, &ovsrec_mirror_col_external_ids);
> +
> +    ovsdb_idl_omit(idl, &ovsrec_netflow_col_external_ids);
> +
> +    ovsdb_idl_omit(idl, &ovsrec_sflow_col_external_ids);
> +
> +    ovsdb_idl_omit(idl, &ovsrec_manager_col_external_ids);
> +    ovsdb_idl_omit(idl, &ovsrec_manager_col_inactivity_probe);

Did you mean "uuid" instead of
"ovsrec_manager_col_inactivity_probe" here?

> +    ovsdb_idl_omit(idl, &ovsrec_manager_col_is_connected);
> +    ovsdb_idl_omit(idl, &ovsrec_manager_col_max_backoff);
> +    ovsdb_idl_omit(idl, &ovsrec_manager_col_status);
> +
> +    ovsdb_idl_omit(idl, &ovsrec_ssl_col_external_ids);
> +
>      /* Register unixctl commands. */
>      unixctl_command_register("fdb/show", bridge_unixctl_fdb_show, NULL);
>      unixctl_command_register("cfm/show", cfm_unixctl_show, NULL);
> -- 
> 1.7.1
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev