[ovs-dev] [daemon 10/10] daemon: Avoid races on pidfile creation.

Ben Pfaff blp at nicira.com
Mon Apr 4 18:01:54 UTC 2011


On Fri, Apr 01, 2011 at 05:13:19PM -0700, Ethan Jackson wrote:
> > + ? ?/* Rename or link it to the ocrrect name. */
> > + ? ?if (overwrite_pidfile) {
> > + ? ? ? ?if (rename(tmpfile, pidfile) < 0) {
> > + ? ? ? ? ? ?VLOG_FATAL("failed to rename \"%s\" to \"%s\" (%s)",
> > + ? ? ? ? ? ? ? ? ? ? ? tmpfile, pidfile, strerror(errno));
> > + ? ? ? ?}
> 
> typo in the comment.
> 
> Looks Good.

Thank you for all the reviews.  I fixed the typo and pushed this
series.



More information about the dev mailing list