[ovs-dev] [PATCH] autopath: Create the autopath action.

Ben Pfaff blp at nicira.com
Mon Apr 11 17:51:09 UTC 2011


On Mon, Apr 11, 2011 at 10:48:41AM -0700, Ethan Jackson wrote:
> > autopath_parse() rejects nonpositive 'id' values but the
> > NXAST_AUTOPATH action description doesn't say that only positive
> > values are valid.
> 
> I'm not sure here whether the correct thing to do is document that
> positive ID  values are required, or loosen the requirement.  From the
> action's perspective, it's just a 4byte id value.  It doesn't
> particularly care if that's interpreted as a two's compliment integer,
> or an unsigned integer. It's just used as a key.  Do you have a
> preference?

I guess only values in the range 1...1023 and OFPP_LOCAL are currently
useful?  I guess I don't care then.  The current code is fine.



More information about the dev mailing list