[ovs-dev] [PATCH 1/2] xenserver: Warn when installing OVS on a bridged system.

Andrew Evans aevans at nicira.com
Tue Apr 12 01:49:20 UTC 2011


The patch looks fine to me. I'd prefer "upgrading" to "installing" in
the commit title, since this only happens on upgrade.

On 4/11/11 6:33 PM, Ethan Jackson wrote:
> ---
>  xenserver/openvswitch-xen.spec |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/xenserver/openvswitch-xen.spec b/xenserver/openvswitch-xen.spec
> index 7a2e176..c445f3d 100644
> --- a/xenserver/openvswitch-xen.spec
> +++ b/xenserver/openvswitch-xen.spec
> @@ -235,6 +235,14 @@ if [ "$1" = "1" ]; then    # $1 = 2 for upgrade
>  else
>      printf "\nTo use the new Open vSwitch install, you should reboot the\n" 
>      printf "server now.  Failure to do so may result in incorrect operation."
> +
> +    mode=$(cat /etc/xensource/network.conf)
> +    if [ "$mode" != "vswitch" ]; then
> +        printf "\n\nThe server is not configured to run Open vSwitch.  To run in\n"
> +        printf "vswitch mode you must run the following command before rebooting.\n"
> +        printf "echo vswitch > /etc/xensource/network.conf"
> +    fi
> +
>      printf "\n\n"
>  fi
>  




More information about the dev mailing list