[ovs-dev] [PATCH] debian: Remove call to obsolete command "ovs-ofctl status" in ovs-bugtool.

Justin Pettit jpettit at nicira.com
Tue Apr 12 17:01:09 UTC 2011


Looks good as an immediate fix.  However, it was useful to know the connectivity of the manager and controller at the time the log was taken.  It's worth just pushing this immediate fix, so the tool stops hanging, though.

--Justin


On Apr 12, 2011, at 9:47 AM, Ben Pfaff wrote:

> This command was removed in commit 9b45d7f5d (ofproto: Get rid of archaic
> "switch status" OpenFlow extension) but I didn't notice that ovs-bugtool
> uses that command and forgot to remove it at the time.
> 
> Bug #5360.
> Reported-by: Michael Mao <mmao at nicira.com>
> Reported-by: Keith Amidon <keith at nicira.com>
> ---
> debian/ovs-bugtool |    3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/debian/ovs-bugtool b/debian/ovs-bugtool
> index 69fe78a..209d937 100755
> --- a/debian/ovs-bugtool
> +++ b/debian/ovs-bugtool
> @@ -14,7 +14,7 @@
> # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> #
> # Copyright (c) 2005, 2007 XenSource Ltd.
> -# Copyright (c) 2010, Nicira Networks.
> +# Copyright (c) 2010, 2011 Nicira Networks.
> 
> #
> # To add new entries to the bugtool, you need to:
> @@ -518,7 +518,6 @@ exclude those logs from the archive.
>         cmd_output(CAP_NETWORK_STATUS, [OVS_DPCTL, 'show'])
>         for d in dp_list():
>             cmd_output(CAP_NETWORK_STATUS, [OVS_OFCTL, 'show', d])
> -            cmd_output(CAP_NETWORK_STATUS, [OVS_OFCTL, 'status', d])
>             cmd_output(CAP_NETWORK_STATUS, [OVS_OFCTL, 'dump-flows', d])
>             cmd_output(CAP_NETWORK_STATUS, [OVS_DPCTL, 'dump-flows', d])
>         try:
> -- 
> 1.7.1
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list