[ovs-dev] [PATCH] bond: Reset bond_entry's during massive flow revalidations.
ethan at nicira.com
Wed Apr 13 21:14:48 UTC 2011
I made both of those changes and will merge shortly.
Thanks for the reviews.
On Wed, Apr 13, 2011 at 2:11 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Apr 13, 2011 at 01:58:24PM -0700, Ethan Jackson wrote:
>> When all flows in a bond are revalidated, stale bond_entry's can
>> cause incorrect load balancing. These issues will naturally
>> resolve themselves overtime. However, it's better to deal with
>> them immediately.
> My only complaints are cosmetic.
> There's a blank line before the first line of code in
> Also in bond_entry_reset(), would you mind putting the assignment to
> bond->next_rebalance after the memset? Then all of the code that
> deals with the hash is grouped together.
More information about the dev