[ovs-dev] [lacp bridge 1/4] lacp: Remove enabled flag.

Ben Pfaff blp at nicira.com
Fri Apr 15 17:05:49 UTC 2011


On Thu, Apr 14, 2011 at 07:09:35PM -0700, Ethan Jackson wrote:
> The enabled flag in the LACP module was only used to set the
> Collecting and Distributing flags in the LACP protocol.  It was
> intended to be set by the bonding code to mimic its enabled flag.
> 
> The spec is relatively vague on the precise meaning of these flags,
> and most implementations do something completely different with
> them.  For these reasons, it seems acceptable to remove the enabled
> flag for the sake of simplicity.  A slave is now Collecting and
> Distributing if it is attached, or LACP couldn't be negotiated.

I'll take your word for it that this is acceptable behavior.  Given
that, the patch looks good to me.



More information about the dev mailing list