[ovs-dev] [warnings 3/3] bridge: Properly test for out-of-range values.
blp at nicira.com
Mon Apr 18 17:33:49 UTC 2011
Thank you for the reviews. I fixed up the merge conflicts and I will
push these soon.
On Fri, Apr 15, 2011 at 12:24:14PM -0700, Ethan Jackson wrote:
> You are going to have merge conflicts with this patch I suspect, but
> the approach seems fine to me.
> On Fri, Apr 15, 2011 at 9:41 AM, Ben Pfaff <blp at nicira.com> wrote:
> > This code was trying to check for priorities greater than UINT16_MAX and
> > reset them, but it assigned the value to a uint16_t before it checked it,
> > which of course hid the problem.
> > Fixes the following GCC warning:
> > vswitchd/bridge.c:3034: warning: comparison is always false due to limited
> > range of data type
> > Reported-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
More information about the dev