[ovs-dev] [PATCH 3/3] bridge: Report lacp_slave_is_current() in the database.

Ethan Jackson ethan at nicira.com
Mon Apr 18 17:49:20 UTC 2011


Thanks for the reviews, I merged this series.

Ethan

On Mon, Apr 18, 2011 at 10:25 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Apr 15, 2011 at 01:49:19PM -0700, Ethan Jackson wrote:
>> Whether or not a given slave is current with its LACP protocol
>> messages can be very interesting to a controller.  If an interface
>> is not current, it usually indicates a connectivity problem or
>> misconfiguration of some sort.
>
> There is a missing space before the '=' in the initializer for
> db_current in iface_refresh_lacp_stats().
>
> In vswitch.xml, I would add a sentence something like, "This column
> will be empty if LACP is not enabled."
>
> Otherwise this looks good.  Thank you!
>



More information about the dev mailing list