[ovs-dev] [bond 2/2] bond: Fix ugly warnings at slave registration.

Ethan Jackson ethan at nicira.com
Mon Apr 18 23:27:28 UTC 2011


I debated doing that.  I suppose it would be fine.  The most straight
forward way would be to malloc it in the if (!slave) conditional, it
would later be freed and then realloced in the same function.  Not a
big deal though.

Ethan

On Mon, Apr 18, 2011 at 4:25 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Apr 18, 2011 at 04:20:35PM -0700, Ethan Jackson wrote:
>> Before this patch, when a slave was registered for this first time
>> the following warning would display.
>>
>> interface (null): enabled
>>
>> This is because the slave was enabled before having its name
>> configured.  This patch fixes the problem by not warning in
>> bond_enable_slave() when the given slave hasn't had its name
>> initialized.
>
> Could we instead set the name earlier?  It is sometimes useful in
> debugging to know whether a bond is initially up.
>



More information about the dev mailing list