[ovs-dev] [PATCH 2/2] bond: Fix ugly warnings at slave registration.

Ethan Jackson ethan at nicira.com
Mon Apr 18 23:31:39 UTC 2011


Oops, sorry forgot to add the subject prefix.  This is part of the
"bond" series.

Ethan

On Mon, Apr 18, 2011 at 4:30 PM, Ethan Jackson <ethan at nicira.com> wrote:
> Before this patch, when a slave was registered for this first time
> the following warning would display.
>
> interface (null): enabled
>
> This is because the slave was enabled before having its name
> configured.
> ---
>  lib/bond.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/lib/bond.c b/lib/bond.c
> index d826c33..d3b0e30 100644
> --- a/lib/bond.c
> +++ b/lib/bond.c
> @@ -376,6 +376,8 @@ bond_slave_register(struct bond *bond, void *slave_, uint16_t stb_id,
>         slave->aux = slave_;
>         slave->delay_expires = LLONG_MAX;
>         slave->up = bond_is_link_up(bond, netdev);
> +        slave->name = xstrdup(netdev_get_name(netdev));
> +
>         slave->enabled = false;
>         bond_enable_slave(slave, slave->up, NULL);
>     }
> --
> 1.7.4.2
>
>



More information about the dev mailing list