[ovs-dev] [PATCH 1/3] lacp: Move LACP packet data to lacp header file.

Ben Pfaff blp at nicira.com
Tue Apr 19 16:39:55 UTC 2011


Looks fine.

As an idea for later, you could actually move all of these definitions
that are now in lacp.h into lacp.c, if you did two more things: made
lacp_process_pdu() take the whole frame and parse it itself, and made
the lacp_run() callback take a const void * and a length instead of a
structure.



More information about the dev mailing list