[ovs-dev] [PATCH 3/3] lacp: Implement custom timing mode.

Ben Pfaff blp at nicira.com
Tue Apr 19 16:49:46 UTC 2011


On Mon, Apr 18, 2011 at 02:32:46PM -0700, Ethan Jackson wrote:
> With this patch, the LACP module may be manually configured to use
> an arbitrary transmission rate set in the database.

It seems to me that there are several instances of code that is
something like 
   lacp_time == LACP_TIME_CUSTOM ? lacp->custom_time
   : lacp_time == LACP_TIME_FAST ? LACP_FAST_TIME_TX
   : LACP_SLOW_TIME_TX
I'd suggest using a helper function or a member in struct lacp to
avoid the repetition.  Even two helpers or members, if you want both rx
and tx rates.

There should probably be a minimum time.  Maybe TIME_UPDATE_INTERVAL
(currently 100 ms).

I think that the vswitch.xml documentation should mention what the
"slow" and "fast" intervals actually are, so that people choosing
custom times have some frame of reference.

Thanks,

Ben.



More information about the dev mailing list