[ovs-dev] [PATCH 3/3] lacp: Implement custom timing mode.

Ethan Jackson ethan at nicira.com
Tue Apr 19 19:55:26 UTC 2011


> and in slave_set_expired():
>
>    duration = rx_duration(lacp, lacp->lacp_time == LACP_TIME_FAST);
>    timer_set_duration(&slave->rx, duration);

This doesn't precisely work the same as the existing code. According
to the LACP spec, when in expired state you are supposed to wait 3 *
LACP_TIME_FAST seconds.  However, that isn't fast enough for us in
custom mode, so when using custom time we simply wait 1 * custom_time
seconds.  I could use the functions you suggested for the other two
cases if you still think it's worth it.  I'll send out an incremental.
 I'm kinda neutral on it, not sure it adds value, but it doesn't hurt
either.

Ethan



More information about the dev mailing list