[ovs-dev] [PATCH 3/3] lacp: Implement custom timing mode.

Ben Pfaff blp at nicira.com
Tue Apr 19 20:00:12 UTC 2011


On Tue, Apr 19, 2011 at 12:55:26PM -0700, Ethan Jackson wrote:
> > and in slave_set_expired():
> >
> > ? ?duration = rx_duration(lacp, lacp->lacp_time == LACP_TIME_FAST);
> > ? ?timer_set_duration(&slave->rx, duration);
> 
> This doesn't precisely work the same as the existing code. According
> to the LACP spec, when in expired state you are supposed to wait 3 *
> LACP_TIME_FAST seconds.  However, that isn't fast enough for us in
> custom mode, so when using custom time we simply wait 1 * custom_time
> seconds.

OK.  I didn't notice that subtlety.  Just do what you think is best,
then.

Thanks,

Ben.



More information about the dev mailing list