[ovs-dev] [PATCH] Remove support for obsolete "tun_id_from_cookie" extension.

Ethan Jackson ethan at nicira.com
Thu Apr 21 20:43:43 UTC 2011


I didn't review this super closely.  Looks fine to me.  One comment.

> @@ -2830,8 +2829,7 @@ put_ofp_flow_stats(struct ofconn *ofconn, struct rule *rule,
>     ofs->length = htons(len);
>     ofs->table_id = 0;
>     ofs->pad = 0;
> -    ofputil_cls_rule_to_match(&rule->cr, ofconn_get_flow_format(ofconn),
> -                              &ofs->match, rule->flow_cookie, &cookie);
> +    ofputil_cls_rule_to_match(&rule->cr, &ofs->match);
>     put_32aligned_be64(&ofs->cookie, cookie);

It looks like cookie is used uninitialzed here due to the patch.



More information about the dev mailing list