[ovs-dev] [PATCH] datapath: Remove dead code in queue_control_packets().

Ethan Jackson ethan at nicira.com
Fri Apr 29 00:18:56 UTC 2011


First kernel patch!  Super useful too!

Compile tested only.
Ethan

On Thu, Apr 28, 2011 at 17:18, Ethan Jackson <ethan at nicira.com> wrote:
> Fixes the following warning:
>
> datapath.c:473:6: warning: variable 'port_no' set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Ethan Jackson <ethan at nicira.com>
> ---
>  datapath/datapath.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 5ce77cd..c772c81 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -470,14 +470,8 @@ static int queue_control_packets(struct datapath *dp, struct sk_buff *skb,
>  {
>        u32 group = packet_mc_group(dp, upcall_info->cmd);
>        struct sk_buff *nskb;
> -       int port_no;
>        int err;
>
> -       if (OVS_CB(skb)->vport)
> -               port_no = OVS_CB(skb)->vport->port_no;
> -       else
> -               port_no = ODPP_LOCAL;
> -
>        do {
>                struct odp_header *upcall;
>                struct sk_buff *user_skb; /* to be queued to userspace */
> --
> 1.7.4.4
>
>



More information about the dev mailing list