[ovs-dev] [PATCH 1/3] tunnel: Add df_default and df_inherit tunnel options.

[Andrew Evans]

On Thu, 2011-04-28 at 16:53 -0700, Jesse Gross wrote:
> On Wed, Apr 27, 2011 at 2:59 PM, Andrew Evans <aevans at nicira.com> wrote:
> > +#define TNL_F_DF_DEFAULT       (1 << 4) /* Set the DF bit if inherit off or not IP? */
> 
> I'm assuming that the comment wasn't meant to be a question...

I guess that's the way I tend to think about flags, but I wasn't paying
enough attention to stylistic consistency there. Changed.

> > @@ -709,6 +709,14 @@ parse_tunnel_config(const char *name, const char *type,
> >             if (!strcmp(node->data, "true")) {
> >                 flags |= TNL_F_CSUM;
> >             }
> > +        } else if (!strcmp(node->name, "df_inherit")) {
> > +            if (!strcmp(node->data, "true")) {
> > +                flags &= TNL_F_DF_INHERIT;
> > +            }
> 
> This should be |= to turn the flag on.

Oops. Thanks.

> I think these three commits should really be one.  This adds a
> userspace interface that is broken and the next a feature that is not
> documented so they're not really independent pieces.

Agreed. I've squashed them. Thanks.