[ovs-dev] [PATCH] [patch v2] ovs-dpctl: Show number of flows
Simon Horman
horms at verge.net.au
Wed Aug 3 23:04:10 UTC 2011
Expose the number of flows present in a datapath to user-space
and to users via ovs-dpctl show.
e.g.:
ovs-dpctl show br3
system at br3:
lookups: frags:0, hit:0, missed:0, lost:0
flows: 0
...
Signed-off-by: Simon Horman <horms at verge.net.au>
---
v2
Expose n_flows by extending odp_stats rather than
adding a new netlink attribute. This is simpler and
acceptable as the userspace/kernel interface isn't
locked down yet.
---
datapath/datapath.c | 3 +++
include/openvswitch/datapath-protocol.h | 1 +
utilities/ovs-dpctl.c | 1 +
3 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index 3ec5be4..b191239 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -747,6 +747,9 @@ static struct genl_ops dp_packet_genl_ops[] = {
static void get_dp_stats(struct datapath *dp, struct odp_stats *stats)
{
int i;
+ struct tbl *table = get_table_protected(dp);
+
+ stats->n_flows = tbl_count(table);
stats->n_frags = stats->n_hit = stats->n_missed = stats->n_lost = 0;
for_each_possible_cpu(i) {
diff --git a/include/openvswitch/datapath-protocol.h b/include/openvswitch/datapath-protocol.h
index 0b755e8..426236c 100644
--- a/include/openvswitch/datapath-protocol.h
+++ b/include/openvswitch/datapath-protocol.h
@@ -133,6 +133,7 @@ struct odp_stats {
uint64_t n_hit; /* Number of flow table matches. */
uint64_t n_missed; /* Number of flow table misses. */
uint64_t n_lost; /* Number of misses not sent to userspace. */
+ uint64_t n_flows; /* Number of flows present */
};
/* Logical ports. */
diff --git a/utilities/ovs-dpctl.c b/utilities/ovs-dpctl.c
index c7350e5..415d276 100644
--- a/utilities/ovs-dpctl.c
+++ b/utilities/ovs-dpctl.c
@@ -369,6 +369,7 @@ show_dpif(struct dpif *dpif)
(unsigned long long int) stats.n_hit,
(unsigned long long int) stats.n_missed,
(unsigned long long int) stats.n_lost);
+ printf("\tflows: %llu\n", (unsigned long long int)stats.n_flows);
}
DPIF_PORT_FOR_EACH (&dpif_port, &dump, dpif) {
printf("\tport %u: %s", dpif_port.port_no, dpif_port.name);
--
1.7.5.4
More information about the dev
mailing list