[ovs-dev] [netdevs 3/4] netdev: Decouple creating and configuring network devices.

Ben Pfaff blp at nicira.com
Mon Aug 8 19:54:30 UTC 2011


On Mon, Aug 08, 2011 at 12:03:29PM -0700, Ethan Jackson wrote:
> The indentation is messed up at the definition of netdev_linux_create().

OK, fixed.

> netdev_vport_set_config() always writes the configuration to the
> datapath if the given netdev's options are NULL.   I would think that
> it would be common for the datapath to already have the exact same
> configuration installed from a previous run of vswitchd.  Would it
> make sense to automatically run netdev_vport_get_config() at creation
> time?

I'm not sure that there is an advantage to that.  Whether we do a
get_config or a set_config, it's one system call.



More information about the dev mailing list