[ovs-dev] [multiple tables 3/8] ofproto-dpif: Make ofproto/trace accept an odp_flow in place of a packet.
Ethan Jackson
ethan at nicira.com
Mon Aug 8 22:35:39 UTC 2011
The indentation is slightly messed up in the man page (when viewed
with "man"). The first occurrence of "ovs-vswitchd will respond
with extensive" should be indented further like the second occurrence
is.
Also, I noticed another problem in ofproto_unixctl_trace() which I
don't think was introduced by this patch. trace_format_rule()
dereferences the result of rule_dpif_lookup() before checking if it's
NULL. Seems like trace_format_rule should really take a rule_dpif
instead.
Otherwise looks good,
Ethan
More information about the dev
mailing list