[ovs-dev] [PATCH] Option to forward BPDU (Ethernet control class) frames

Ben Pfaff blp at nicira.com
Tue Aug 9 16:00:07 UTC 2011


On Mon, Aug 08, 2011 at 08:11:48PM -0700, Sanjay Sane wrote:
> Currently, a NORMAL action bridge drops reserved-multicast-mac addresses;
> 01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an
> option to forward such frames.
> 
> This commit proposes to have a configuration option to allow forwarding of
> BPDU class frames.  To ensure backward compatibility, this option is
> disabled by default.

This looks good to me.

I guess that the forward_bpdu_changed() function doesn't need the
new_val parameter at all, since the function can determine the new
value from ofproto->forward_bpdu.  So you could remove that parameter.

Earlier we talked about having me do the actual push for you until you
become comfortable with Git.  If that's still the case, then send the
final version to the list and I'll push it.

Thanks,

Ben.



More information about the dev mailing list