[ovs-dev] [PATCH] connmgr: Remove unused function ofconn_n_pending_opgroups().

Ben Pfaff blp at nicira.com
Mon Aug 15 16:49:09 UTC 2011


Thanks, I'll push this soon.

On Fri, Aug 12, 2011 at 04:51:01PM -0700, Justin Pettit wrote:
> Looks fine to me.
> 
> --Justin
> 
> 
> On Aug 10, 2011, at 3:05 PM, Ben Pfaff wrote:
> 
> > ---
> > ofproto/connmgr.c |    7 -------
> > ofproto/connmgr.h |    1 -
> > 2 files changed, 0 insertions(+), 8 deletions(-)
> > 
> > diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c
> > index 38052ac..2d0b8c5 100644
> > --- a/ofproto/connmgr.c
> > +++ b/ofproto/connmgr.c
> > @@ -849,13 +849,6 @@ ofconn_has_pending_opgroups(const struct ofconn *ofconn)
> >     return !list_is_empty(&ofconn->opgroups);
> > }
> > 
> > -/* Returns the number of pending opgroups on 'ofconn'. */
> > -size_t
> > -ofconn_n_pending_opgroups(const struct ofconn *ofconn)
> > -{
> > -    return list_size(&ofconn->opgroups);
> > -}
> > -
> > /* Adds 'ofconn_node' to 'ofconn''s list of pending opgroups.
> >  *
> >  * If 'ofconn' is destroyed or its connection drops, then 'ofconn' will remove
> > diff --git a/ofproto/connmgr.h b/ofproto/connmgr.h
> > index 31416a1..ea39b72 100644
> > --- a/ofproto/connmgr.h
> > +++ b/ofproto/connmgr.h
> > @@ -98,7 +98,6 @@ void ofconn_send_error(const struct ofconn *, const struct ofp_header *request,
> > int ofconn_pktbuf_retrieve(struct ofconn *, uint32_t id,
> >                            struct ofpbuf **bufferp, uint16_t *in_port);
> > 
> > -size_t ofconn_n_pending_opgroups(const struct ofconn *);
> > bool ofconn_has_pending_opgroups(const struct ofconn *);
> > void ofconn_add_opgroup(struct ofconn *, struct list *);
> > void ofconn_remove_opgroup(struct ofconn *, struct list *,
> > -- 
> > 1.7.4.4
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> 



More information about the dev mailing list