[ovs-dev] [PATCH] ofp-print: Add missing "break".

Ben Pfaff blp at nicira.com
Mon Aug 15 22:25:04 UTC 2011


Thanks, I pushed this.

On Mon, Aug 15, 2011 at 03:19:19PM -0700, Ethan Jackson wrote:
> Looks good,
> 
> I noticed that quite a while ago, probably should have fixed it then.
> 
> Ethan
> 
> On Mon, Aug 15, 2011 at 15:18, Ben Pfaff <blp at nicira.com> wrote:
> > This is not a bug yet, but it could be the next time someone carelessly
> > adds a new case.
> > ---
> > ?lib/ofp-print.c | ? ?1 +
> > ?1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/ofp-print.c b/lib/ofp-print.c
> > index 4c94ebb..d7804fe 100644
> > --- a/lib/ofp-print.c
> > +++ b/lib/ofp-print.c
> > @@ -368,6 +368,7 @@ ofp_print_action(struct ds *s, const union ofp_action *a,
> > ? ? ? ? nxm_format_field_bits(s, ntohl(naor->src),
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? nxm_decode_ofs(naor->ofs_nbits),
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? nxm_decode_n_bits(naor->ofs_nbits));
> > + ? ? ? ?break;
> >
> > ? ? default:
> > ? ? ? ? break;
> > --
> > 1.7.4.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list