[ovs-dev] [PATCH 2/2] datapath: Disable LRO from userspace instead of the kernel.

Jesse Gross jesse at nicira.com
Sat Aug 20 01:13:56 UTC 2011


On Thu, Aug 18, 2011 at 10:01 AM, Justin Pettit <jpettit at nicira.com> wrote:
> @@ -381,6 +386,10 @@ dpif_linux_port_add(struct dpif *dpif_, struct netdev *netdev,
>         request.options_len = options->size;
>     }
>
> +    if (request.type == ODP_VPORT_TYPE_NETDEV) {
> +        netdev_linux_ethtool_set_flag(netdev, ETH_FLAG_LRO, false);
> +    }

One other thing: the kernel implementation of dev_disable_lro()
fetches the flags again after it disables LRO and checks to see if it
really is disabled, issuing a warning if it isn't.  This sounds
completely unnecessary but I've seen the warning trigger several times
before so maybe we should do that as well.



More information about the dev mailing list