[ovs-dev] [PATCH] Drop spurious 'H' cases from daemon option parsing switch statements.

Ben Pfaff blp at nicira.com
Mon Aug 22 19:55:06 UTC 2011


Thanks, I pushed this.

On Mon, Aug 22, 2011 at 11:02:03AM -0700, Justin Pettit wrote:
> With the "shift" key.  I know you're still finding your way around
> computers, but geez.
> 
> Looks good.
> 
> --Justin
> 
> 
> On Aug 22, 2011, at 10:41 AM, Ben Pfaff wrote:
> 
> > Help is 'h'.  I don't see how 'H' can ever happen.
> > ---
> > vswitchd/ovs-brcompatd.c |    1 -
> > vswitchd/ovs-vswitchd.c  |    1 -
> > 2 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/vswitchd/ovs-brcompatd.c b/vswitchd/ovs-brcompatd.c
> > index c1cc817..c88684f 100644
> > --- a/vswitchd/ovs-brcompatd.c
> > +++ b/vswitchd/ovs-brcompatd.c
> > @@ -880,7 +880,6 @@ parse_options(int argc, char *argv[])
> >         }
> > 
> >         switch (c) {
> > -        case 'H':
> >         case 'h':
> >             usage();
> > 
> > diff --git a/vswitchd/ovs-vswitchd.c b/vswitchd/ovs-vswitchd.c
> > index b2b2082..875da69 100644
> > --- a/vswitchd/ovs-vswitchd.c
> > +++ b/vswitchd/ovs-vswitchd.c
> > @@ -146,7 +146,6 @@ parse_options(int argc, char *argv[])
> >         }
> > 
> >         switch (c) {
> > -        case 'H':
> >         case 'h':
> >             usage();
> > 
> > -- 
> > 1.7.4.4
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> 



More information about the dev mailing list