[ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

[Philippe Jung]

Le 18/08/2011 10:19, Jesse Gross a écrit :
> On Aug 18, 2011 2

> I would make the change everywhere. The above list looks good, although
> I think it might be better to reverse the native names (i.e.
> "native-tagged" instead of "tagged-native") as it groups things together
> a little better.
> 

I am finishing my campaign of tests trying to mix all possible
configuration. However, I have a difference on one test case. I digged
down to a piece of code I don't understand.

In original ofproto-dpif.c, line 1058, I read

1058     /* Get trunked VLANs. */
1059     trunks = s->vlan == -1 ? NULL : s->trunks;

Is there a reason to explain that when the port is trunk (vlan=-1),
trunks is set to nul and when port is access (vlan<>-1) trunks is set to
s->trunk ? I would have inverted the test case.

Philippe