[ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

[Philippe Jung]

Le 23/08/2011 01:16, Ben Pfaff a écrit :
> On Tue, Aug 23, 2011 at 12:54:19AM +0200, Philippe Jung wrote:
>> If needed, I can post my OpenOffice table where I have written all
>> tests I have performed
> 
> That would actually be great.  I'd like to convert them to unit tests.

Regarding the tests:

Please find attached the file.

I use two virtual machines.
First one with eth0 (192.168.2.1, untagged) and eth0.3 (192.168.3.1, tagged)
Second one with eth0 (192.168.2.2, untagged) and eth0:3 (192.168.3.2, untagged)

I try to ping from VM1 192.168.2.2 (Test PING IP.2) and  192.168.3.2 (Test PING IP.3)
I repeat the operation for several configuration for tag/trunk/mode for vm1 and vm2.
If PING IP.2 and PING IP.3 are as expected, the test is passed. Of course, sometimes "as expected" means PING IP.2 is KO and PING IP.3 is KO



Regarding the patch:

In several parts of the files, I left tests such as mode==empty && tag>=0 || mode==access. It could be more efficient to perform the test in bundle_set and never set mode to empty inside ofproto-dpif.c. If vlan_mode is empty in database, then we guess if mode is ACCESS or TRUNK based on tag/trunks fields. Doing so, we do the test once at configuration time and we avoid doing it each time a packet is managed by the switch. I will try to improve the patch this way.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Test cases.ods
Type: application/vnd.oasis.opendocument.spreadsheet
Size: 9995 bytes
Desc: not available
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20110823/105bd601/attachment-0004.ods>