[ovs-dev] [python 17/31] ovs.db.types: Use .append instead of += for adding to lists.

Ben Pfaff blp at nicira.com
Tue Aug 23 21:05:11 UTC 2011


Python does not do a good job of appending lists to lists.

Suggested-by: Reid Price <reid at nicira.com>
---
 python/ovs/db/types.py |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/python/ovs/db/types.py b/python/ovs/db/types.py
index 635922f..f7bc248 100644
--- a/python/ovs/db/types.py
+++ b/python/ovs/db/types.py
@@ -510,14 +510,14 @@ class Type(object):
         keyConstraints = self.key.constraintsToEnglish(escapeLiteral)
         if keyConstraints:
             if self.value:
-                constraints += ['key ' + keyConstraints]
+                constraints.append('key %s' % keyConstraints)
             else:
-                constraints += [keyConstraints]
+                constraints.append(keyConstraints)
 
         if self.value:
             valueConstraints = self.value.constraintsToEnglish(escapeLiteral)
             if valueConstraints:
-                constraints += ['value ' + valueConstraints]
+                constraints.append('value %s' % valueConstraints)
 
         return ', '.join(constraints)
                 
-- 
1.7.4.4




More information about the dev mailing list