[ovs-dev] [python3 01/15] ovs.db.idl: Fix call to ovs.db.parser.Parser constructor.

Justin Pettit jpettit at nicira.com
Thu Aug 25 18:05:02 UTC 2011


Looks good.

--Justin


On Aug 24, 2011, at 5:14 PM, Ben Pfaff wrote:

> This bug was introduced by commit 4c0f62718f "ovs.db.idl: Improve error
> reporting for bad <row-update>s."
> 
> Found by pychecker.
> ---
> python/ovs/db/idl.py |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py
> index dc5f89e..8f3c810 100644
> --- a/python/ovs/db/idl.py
> +++ b/python/ovs/db/idl.py
> @@ -207,7 +207,7 @@ class Idl:
>                                       'is not an object'
>                                       % (table_name, uuid_string))
> 
> -                parser = ovs.db.parser.Parser(json, "row-update")
> +                parser = ovs.db.parser.Parser(row_update, "row-update")
>                 old = parser.get_optional("old", [dict])
>                 new = parser.get_optional("new", [dict])
>                 parser.finish()
> -- 
> 1.7.4.4
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list