[ovs-dev] [python3 02/15] ovs.daemon: Add missing 'global' when setting _pidfile_dev, _pidfile_ino.

Justin Pettit jpettit at nicira.com
Thu Aug 25 18:06:15 UTC 2011


Looks good.

--Justin


On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote:

> Found by pychecker.
> ---
> python/ovs/daemon.py |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/python/ovs/daemon.py b/python/ovs/daemon.py
> index da7eb8a..7bd7370 100644
> --- a/python/ovs/daemon.py
> +++ b/python/ovs/daemon.py
> @@ -182,6 +182,8 @@ def _make_pidfile():
>         if error:
>             _fatal("%s: unlink failed (%s)" % (tmpfile, os.strerror(error)))
> 
> +    global _pidfile_dev
> +    global _pidfile_ino
>     _pidfile_dev = s.st_dev
>     _pidfile_ino = s.st_ino
> 
> -- 
> 1.7.4.4
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list