[ovs-dev] [PATCH 1/3] datapath: RCU'ed dps list.

Jesse Gross jesse at nicira.com
Fri Dec 2 19:40:09 UTC 2011


On Fri, Dec 2, 2011 at 11:00 AM, Pravin B Shelar <pshelar at nicira.com> wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index c86c20b..acbd3bf 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -1544,7 +1544,7 @@ static int ovs_dp_cmd_dump(struct sk_buff *skb, struct netlink_callback *cb)
>        int skip = cb->args[0];
>        int i = 0;
>
> -       list_for_each_entry(dp, &dps, list_node) {
> +       list_for_each_entry_rcu(dp, &dps, list_node) {

I think we should continue to use the old function here because this
usage is protected by genl_mutex, not RCU.



More information about the dev mailing list