[ovs-dev] [PATCH 2/2] sflow: Use ofproto_port_get_stats().

Ben Pfaff blp at nicira.com
Fri Dec 2 22:45:37 UTC 2011


This seems reasonable but I see ways to improve it.  The 'netdev'
member can now be removed from struct dpif_sflow_port since it can get
the same netdev as ofport->netdev.  The 'odp_port' member can also be
removed since it can be calculated using
ofp_port_to_odp_port(ofport->ofp_port).

Also, in a comment, s/retrive/retrieve/.

Thanks,

Ben.



More information about the dev mailing list