[ovs-dev] [PATCH] netdev-linux: Don't restrict policing to IPv4 and don't call "tc".

jamal hadi at cyberus.ca
Mon Dec 5 13:58:06 UTC 2011


Looks good. 
I dont think i deserve the credit you are attributing to me.

Now wouldnt it have been nice to be able to say:

/sbin/tc filter add dev virt0 parent ffff: protocol ip prio 50 u32 \
match ip src 0.0.0.0/0 \
action police rate Xkbit drop \
action vlan pop \
action vlan push tag XXX \
action ip set 10.0.0.1 
action checksum \
action blah \
flowid :1

Yes, that uses the same API you just used to set the policer.

cheers,
jamal

On Sun, 2011-12-04 at 16:57 -0800, Justin Pettit wrote:
> Mike Bursell pointed out that our policer only works on IPv4
> traffic--and specifically not IPv6.  By using the "basic" filter, we can
> enforce policing on all traffic for a particular interface.
> 
> Jamal Hadi Salim pointed out that calling "tc" directly with system() is
> pretty ugly.  This commit switches our remaining "tc" calls to directly
> sending the appropriate netlink messages.
> 
> Suggested-by: Mike Bursell <mike.bursell at citrix.com>
> Suggested-by: Jamal Hadi Salim <hadi at cyberus.ca>
> ---
>  AUTHORS            |    2 +
>  INSTALL.Linux      |    6 +-
>  lib/netdev-linux.c |  191 +++++++++++++++++++++++++++++++++++----------------
>  3 files changed, 136 insertions(+), 63 deletions(-)
> 
> diff --git a/AUTHORS b/AUTHORS
> index 6cf99da..964e32d 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -78,6 +78,7 @@ Hassan Khan             hassan.khan at seecs.edu.pk
>  Hector Oron             hector.oron at gmail.com
>  Henrik Amren            henrik at nicira.com
>  Jad Naous               jnaous at gmail.com
> +Jamal Hadi Salim        hadi at cyberus.ca







More information about the dev mailing list