[ovs-dev] [PATCH 1/2] ofproto: Device stats should include packets generated by userspace/controller
Ben Pfaff
blp at nicira.com
Thu Dec 8 19:34:02 UTC 2011
On Thu, Dec 08, 2011 at 11:30:27AM -0800, Pravin Shelar wrote:
> On Fri, Dec 2, 2011 at 2:38 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Fri, Dec 02, 2011 at 02:17:04PM -0800, Pravin B Shelar wrote:
> >> Following patch account packets consumed and composed in userspace
> >> as received on and transmitted from local port.
>
> > Also I think we should only do the updates there if each
> > stats->*_packets is != UINT64_MAX.
>
> I am not sure, isn't checking for error from netdev_get_stats enough?
I know that there's hardware that can only support counting bytes or
packets but not both, at least on at per-flow basis. Anyone out there
know whether this is true for Ethernet ports (or tunnels) too?
If no one speaks up quickly then I guess this is good enough.
Thanks,
Ben.
More information about the dev
mailing list