[ovs-dev] [PATCH v2 1/2] ofproto: Device stats should include packets generated by userspace/controller

Ben Pfaff blp at nicira.com
Thu Dec 8 20:56:29 UTC 2011


On Thu, Dec 08, 2011 at 12:53:33PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> v1-v2:
>         - updated comments
>         - added UINT64_MAX check before updating stats
>         - removed memset from ofproto_port_get_stats()

Looking again, I think you also need to zero the new 'stats' member in
construct(), I don't see anything else that ensures that this is
initialized.

Otherwise, thanks, this looks good.



More information about the dev mailing list