[ovs-dev] [flow-stats 00/14] flow stats fixes plus NetFlow unit tests

Ben Pfaff blp at nicira.com
Thu Dec 8 22:01:25 UTC 2011


The first patch in this series fixes flow statistics that were broken
a while back.

The rest culminates in adding basic unit tests for NetFlow, which is
the context in which the incorrect flow statistics was first noticed.

Ben Pfaff (14):
  ofproto-dpif: Include datapath flow misses in flow statistics.
  netdev-linux: Translate errno value to name in log message.
  netdev-linux: Report error for truncated packets on receive.
  socket-util: Don't try to listen to a UDP socket.
  unixctl: Implement quoting.
  packets: New function eth_from_hex().
  netdev-dummy: Allow injecting traffic.
  poll-loop: Track the poll timeout as an absolute, not a relative
    time.
  timeval: Add ability to fast-forward time, for unit testing.
  flow: Make flow_compose() fake packets slightly more realistic.
  tests: Update ovs-vswitchd log messages to ignore.
  tests: Add expected output parameter to OVS_VSWITCHD_START.
  netflow: Move packet definitions to header file.
  netflow: Add basic unit tests.

 lib/automake.mk           |    1 +
 lib/bond.c                |   96 +++++---------
 lib/cfm.c                 |   13 +-
 lib/coverage.c            |    9 +-
 lib/dummy.c               |    3 +-
 lib/dummy.h               |    3 +-
 lib/flow.c                |    3 +
 lib/lacp.c                |   14 +-
 lib/netdev-dummy.c        |  161 +++++++++++++++++++++--
 lib/netdev-linux.c        |    8 +-
 lib/netdev-provider.h     |    3 +
 lib/netflow.h             |   80 +++++++++++
 lib/packets.c             |   25 ++++
 lib/packets.h             |    3 +
 lib/poll-loop.c           |   56 ++++----
 lib/socket-util.c         |    2 +-
 lib/stress.c              |   63 ++++-----
 lib/timeval.c             |   77 ++++++++++-
 lib/timeval.h             |    3 +-
 lib/unixctl.c             |   80 ++++++++----
 lib/unixctl.h             |    7 +-
 lib/vlog.c                |   37 ++++--
 ofproto/netflow.c         |   57 +--------
 ofproto/netflow.h         |    4 +-
 ofproto/ofproto-dpif.c    |  106 +++++++--------
 ofproto/ofproto.c         |    7 +-
 ovsdb/ovsdb-server.c      |   17 ++-
 tests/automake.mk         |    4 +
 tests/ofproto-dpif.at     |  183 ++++++++++++++++++++-----
 tests/ofproto-macros.at   |   12 ++-
 tests/test-netflow.c      |  323 +++++++++++++++++++++++++++++++++++++++++++++
 utilities/ovs-appctl.8.in |    6 -
 utilities/ovs-appctl.c    |   18 +--
 vswitchd/bridge.c         |   27 ++--
 vswitchd/ovs-vswitchd.c   |    6 +-
 35 files changed, 1111 insertions(+), 406 deletions(-)
 create mode 100644 lib/netflow.h
 create mode 100644 tests/test-netflow.c

-- 
1.7.4.4




More information about the dev mailing list