[ovs-dev] [PATCH 5/7] utilities: install ovs-lib.sh as data not a script

Chris Wright chrisw at sous-sol.org
Fri Dec 9 07:36:04 UTC 2011


Currently, ovs-lib.sh is installed as an executable.  It's meant to be
sourced by external scripts, so install as data.  Fixes rpmlint error:

 E: script-without-shebang /usr/share/openvswitch/scripts/ovs-lib.sh

Could drop the .sh suffix in another commit.

Signed-off-by: Chris Wright <chrisw at sous-sol.org>
---
 Makefile.am           |    2 ++
 utilities/automake.mk |    3 ++-
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 51441ce..46de7fb 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -59,6 +59,7 @@ dist_pkgdata_DATA =
 dist_pkgdata_SCRIPTS =
 dist_sbin_SCRIPTS =
 dist_scripts_SCRIPTS =
+dist_scripts_DATA =
 INSTALL_DATA_LOCAL =
 UNINSTALL_LOCAL =
 man_MANS =
@@ -74,6 +75,7 @@ OVSIDL_BUILT =
 pkgdata_DATA =
 sbin_SCRIPTS =
 scripts_SCRIPTS =
+scripts_DATA =
 SUFFIXES =
 check_DATA =
 
diff --git a/utilities/automake.mk b/utilities/automake.mk
index df94dd1..1c8a56b 100644
--- a/utilities/automake.mk
+++ b/utilities/automake.mk
@@ -13,7 +13,8 @@ bin_SCRIPTS += \
 	utilities/ovs-vlan-test
 endif
 noinst_SCRIPTS += utilities/ovs-pki-cgi
-scripts_SCRIPTS += utilities/ovs-ctl utilities/ovs-lib.sh utilities/ovs-save
+scripts_SCRIPTS += utilities/ovs-ctl utilities/ovs-save
+scripts_DATA += utilities/ovs-lib.sh
 
 EXTRA_DIST += \
 	utilities/ovs-ctl.in \
-- 
1.7.7.3



More information about the dev mailing list