[ovs-dev] [PATCH] SubmittingPatches: Suggest parentheses for commit subjects.

Ben Pfaff blp at nicira.com
Tue Dec 13 22:21:13 UTC 2011


Thanks, I added a sign-off and pushed.

On Tue, Dec 13, 2011 at 02:18:40PM -0800, Ethan Jackson wrote:
> Needs a Signed-off-by (I think).  Otherwise looks good, thanks.
> 
> Ethan
> 
> On Tue, Dec 13, 2011 at 14:15, Ben Pfaff <blp at nicira.com> wrote:
> > Suggested-by: Ethan Jackson <ethan at nicira.com>
> > ---
> > ?SubmittingPatches | ? ?4 ++--
> > ?1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/SubmittingPatches b/SubmittingPatches
> > index f454c3a..c16673f 100644
> > --- a/SubmittingPatches
> > +++ b/SubmittingPatches
> > @@ -87,8 +87,8 @@ reader can see it for himself.
> >
> > ?If the patch refers to a commit already in the Open vSwitch
> > ?repository, please include both the commit number and the subject of
> > -the patch, e.g. 'commit 632d136c "vswitch: Remove restriction on
> > -datapath names."'.
> > +the patch, e.g. 'commit 632d136c (vswitch: Remove restriction on
> > +datapath names.)'.
> >
> > ?If you, the person sending the patch, did not write the patch
> > ?yourself, then the very first line of the body should take the form
> > --
> > 1.7.4.4
> >



More information about the dev mailing list