[ovs-dev] [PATCH] ofproto-dpif: Flush MACs for deleted ports from every bridge.

Ben Pfaff blp at nicira.com
Thu Dec 15 17:35:14 UTC 2011


On Wed, Dec 14, 2011 at 02:50:43PM -0800, Ethan Jackson wrote:
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ?tag_set_add(&o->revalidate_set, e->tag);
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ?mac_learning_expire (o->ml, e);
> 
> Redundant space in this function call.

Thanks, removed.

> As I read this, I was wondering if we could somehow expose the
> all_ofprotos map in ofproto.c to providers by implementing some sort
> of iterator at that level.  The current code is pretty simple and
> straightforward, so it may not be worth it.  Looks good either way.

I thought about the same thing while I was writing the code.  I ended
up with the status quo because, as you say, it was already pretty
simple.

I think I'm going to try to write some unit tests for this before I
push it.

Thanks,

Ben.



More information about the dev mailing list