[ovs-dev] [PATCH] vswitchd: In-band rules for Controller are missing after executing force-reload-kmod command

Ethan Jackson ethan at nicira.com
Mon Dec 19 21:43:18 UTC 2011

>> In current implementation vswitchd adds Controller in-band rules only if there is a route in
>> kernel routing table that might route traffic to the Controller. But, when executing
>> force-reload-kmod command, network configuration (e.g. assigned IP addresses, routes) are flushed
>> away, hence Controller in-band rules are not added.

I haven't read this patch, just noticed that the lines in the commit
message are a bit long.  Could you please limit them to 79 characters
a described in SubmittingPatches?


>> This commit fixes this limitation and allows vswitchd to add Controller in-band rules
>> even if there are no routes in the kernel routing table.
>> Issue: #8625
>> Signed-off-by: Ansis Atteka <aatteka at nicira.com>
> I agree that this change makes sense.  But I think that we already
> have a few instances of similar logic (grep for "tcp:") and it would
> be nice to at least centralize the logic in, say, stream.c, and
> possibly to make this logic a member function of the stream_provider.
> Thanks,
> Ben.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev

More information about the dev mailing list