[ovs-dev] [packet_in 05/13] ofp-print: Remove tcpdump from ofp_packet_to_string().

[Ben Pfaff]

On Wed, Dec 28, 2011 at 05:52:32PM -0800, Ethan Jackson wrote:
> Instead this patch uses flow_format() which gives very similar
> output.  This patch will improve the reliability of unit tests in
> future patches which rely on the results of ofp_packet_to_string().

This looks good as far as it goes but it deserves a few refinements:

        * Drop the paragraph that mentions tcpdump from INSTALL.Linux.

        * Drop the line
                AT_SKIP_IF([test ! -x /usr/sbin/tcpdump])
          from ofp-print.at.

        * Drop the indirection through a file named stdout from
          ofp-print.at and the comment about tcpdump, so that the
          expected output replaces [stdout] in the first AT_CHECK in
          that test. 

Thanks,

Ben.