[ovs-dev] [PATCH] ovs-ofctl: Fix "cookie mask" issue in diff-flows command.

Justin Pettit jpettit at nicira.com
Sat Dec 31 18:03:20 UTC 2011

On Dec 31, 2011, at 8:10 AM, Ben Pfaff wrote:

> On Fri, Dec 30, 2011 at 06:04:53PM -0800, Justin Pettit wrote:
>> Commit e729e79 (Add ability to restrict flow mods and flow stats
>> requests to cookies.) introduced a cookie_mask field to the
>> ofputil_flow_stats_request struct that allowed restricting the flows to
>> a particular cookie pattern.  The diff-flows command uses the
>> read_flows_from_switch() function, which did not properly initialize
>> this field, which would cause it to miss flows.  This commit sets the
>> value to zero, which allows any cookie.
>> Bug #8984
> Looks good to me.  Thanks for tracking this down.

Thanks.  I pushed this.


More information about the dev mailing list