[ovs-dev] [PATCH] xenserver: Add support for disabling in-band management via XAPI.

Andrew Evans aevans at nicira.com
Tue Mar 1 02:31:04 UTC 2011


On 2/28/11 3:17 PM, Ethan Jackson wrote:
>> +
>> +        # Change bridge disable_in_band option if XAPI and OVS states differ.
>> +        xapi_dib = network['other_config'].get('vswitch-disable-in-band')
>> +        if not xapi_dib:
> I think we should enumerate the valid possibilities here e.g.:
> if xapi_dib not in ['true', 'false']:

Ok, the behavior now is that if the value is 'true' or 'false', it gets
set in OVSDB. If it's empty ('' or None), it gets cleared in OVSDB.
Otherwise, an error is logged. This is true of all three scripts, though
in the XAPI plugin the error is returned to the caller rather than being
logged.

> Otherwise looks good.  Go ahead and merge when you are ready.

Thanks, I've pushed it to master.

-Andrew




More information about the dev mailing list