[ovs-dev] [coverity3 00/13] another series of coverity fixes

Ben Pfaff blp at nicira.com
Wed Feb 23 21:24:43 UTC 2011


I believe that this finishes out all of the Coverity-related
issues.  Only the first 3 of these fix actual bugs, as far as
I can tell.  The rest are nice (and generally minor) code
improvements.

Ben Pfaff (13):
  bridge: Ethernet address is 6 bytes, not 4 or 8.
  process: Avoid late failure if /dev/null cannot be opened.
  stream: Make stream_report_content() tolerate negative size.
  leak-checker: Avoid printing freed pointer.
  rconn: Clarify rconn_run_wait().
  ovsdb-idl: JSONRPC_REPLY message always has nonnull 'id'.
  ovs-brcompatd: Simplify code in brc_recv_update().
  ovs-vsctl: Simplify parse_column_key_value().
  ovs-kill: Remove.
  ovs-vsctl: Clarify that uuid_from_string() shouldn't fail in
    post_create().
  dhcp-client: Remove useless call to timeout() from send_reliably().
  test-ovsdb: Check uuid_from_string() return value.
  ovsdb: Explicitly ignore sscanf() return value in is_valid_version().

 INSTALL.Linux                      |    2 +-
 debian/openvswitch-switch.install  |    1 -
 debian/openvswitch-switch.manpages |    1 -
 lib/dhcp-client.c                  |    1 -
 lib/leak-checker.c                 |    3 +-
 lib/ovsdb-idl.c                    |    5 +-
 lib/process.c                      |   24 +++-
 lib/rconn.c                        |    9 +-
 lib/stream.c                       |    4 +-
 lib/stream.h                       |    5 +-
 ovsdb/ovsdb.c                      |    2 +-
 tests/test-ovsdb.c                 |    6 +-
 utilities/.gitignore               |    2 -
 utilities/automake.mk              |    7 --
 utilities/ovs-kill.8.in            |   60 ----------
 utilities/ovs-kill.c               |  208 ------------------------------------
 utilities/ovs-vsctl.c              |   72 +++++--------
 vswitchd/bridge.c                  |    2 +-
 vswitchd/ovs-brcompatd.c           |   45 ++++++---
 xenserver/openvswitch-xen.spec     |    2 -
 20 files changed, 96 insertions(+), 365 deletions(-)
 delete mode 100644 utilities/ovs-kill.8.in
 delete mode 100644 utilities/ovs-kill.c

-- 
1.7.2.3





More information about the dev mailing list