[ovs-dev] [PATCH 1/2] ofproto: Reset facet's rs_used at rule changes.

Ethan Jackson ethan at nicira.com
Thu Feb 24 22:22:22 UTC 2011


When a facet changes rules it's 'used' timer is set to the new
rule's created time.  This is possibly before the time stored in
'rs_used' which could cause an assertion failure in
facet_push_stats().

Bug #4732.
---
 ofproto/ofproto.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 8af1814..456dcb1 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -2566,6 +2566,7 @@ facet_revalidate(struct ofproto *ofproto, struct facet *facet)
         list_push_back(&new_rule->facets, &facet->list_node);
         facet->rule = new_rule;
         facet->used = new_rule->created;
+        facet->rs_used = facet->used;
     }
 
     ofpbuf_delete(odp_actions);
-- 
1.7.4.1





More information about the dev mailing list